Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matter exception NoneType in set_brightness for optional min/max level values #95949

Merged

Conversation

neocolis
Copy link
Contributor

@neocolis neocolis commented Jul 6, 2023

Proposed change

  • Fixes NoneType exception being thrown when trying to dim matter lights (Tapo S505D light in this case) when the minLevel and maxLevel values in LevelControl are not defined.
  • Fixes incorrect minLevel value for get_brightness as the spec lists a minimum value of 1 as the minLevel for LevelControl.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@neocolis neocolis requested a review from a team as a code owner July 6, 2023 01:26
@home-assistant
Copy link

home-assistant bot commented Jul 6, 2023

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@neocolis neocolis force-pushed the matter-light-setbrightness-fix branch from 8e68b30 to 201fb7c Compare July 6, 2023 02:19
@home-assistant
Copy link

home-assistant bot commented Jul 6, 2023

Hi @neocolis

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@marcelveldt
Copy link
Member

marcelveldt commented Jul 6, 2023

Thanks!

The devices I tested so far all had these min/max values defined so missed this.
I assume you tested on you device and it now works as expected!

@home-assistant home-assistant deleted a comment from home-assistant bot Jul 6, 2023
@marcelveldt marcelveldt added this to the 2023.7.1 milestone Jul 6, 2023
@MartinHjelmare MartinHjelmare changed the title Fix exception NoneType in set_brightness for optional min/max level values Fix matter exception NoneType in set_brightness for optional min/max level values Jul 6, 2023
@marcelveldt marcelveldt merged commit 63cb509 into home-assistant:dev Jul 6, 2023
balloob pushed a commit that referenced this pull request Jul 6, 2023
…level values (#95949)

Fix exception NoneType in set_brightness for optional min/max level values
@balloob balloob mentioned this pull request Jul 6, 2023
joostlek pushed a commit to joostlek/core that referenced this pull request Jul 6, 2023
…level values (home-assistant#95949)

Fix exception NoneType in set_brightness for optional min/max level values
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants