Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metadata to pyproject.toml #12770

Merged
merged 3 commits into from
May 25, 2022
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 25, 2022

Proposed change

Similar to home-assistant/core#72422
Move metadata keys from setup.cfg to pyproject.toml.

Depends on home-assistant/actions#71

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

script/version_bump.js Outdated Show resolved Hide resolved
Comment on lines 31 to 32
with:
metadata-file: pyproject.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure about that, why does not the action just handle it regardless of which of the meta file types that are used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I was overcomplicating things. Updated home-assistant/actions#71 as well.

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Needs to wait for the action to be updated before merging.

@cdce8p
Copy link
Member Author

cdce8p commented May 25, 2022

✅ Needs to wait for the action to be updated before merging.

I think it can be merged now.

@zsarnett zsarnett merged commit f8303bf into home-assistant:dev May 25, 2022
@cdce8p cdce8p deleted the metadata-pep-621 branch May 25, 2022 13:40
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants