have dedicated config sections for aws and gcp #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
kumare3
reviewed
Apr 22, 2020
| if config.AWSConfig.Region != "" { | ||
| snsConfig.Region = config.AWSConfig.Region | ||
| } else { | ||
| snsConfig.Region = config.Region |
There was a problem hiding this comment.
aah this is for backwards compatibility? Can we put a deprecated on this flag? so that we can remove it eventually
There was a problem hiding this comment.
I put a deprecated comment on https://github.com/honnix/flyteadmin/pull/1/files#diff-2cd697d44b48c0070c8e0756ed47b382R141, according to https://blog.golang.org/godoc. Is there a better way for deprecation in go?
|
Thank you for doing this, This looks good to me. Once you merge this I can approve :) |
|
@kumare3 I will merge it to the upstream PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.