Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /lagstat command #43

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Improve /lagstat command #43

merged 8 commits into from
Jun 21, 2022

Conversation

hopskipnfall
Copy link
Owner

/lagstat now counts all instances of (presumably) user-caused lag over 10ms.

@hopskipnfall
Copy link
Owner Author

The lagstat command /lagstat has been rewritten entirely. The command now shows how many "tiny" lag spikes (between 10mx and 70ms) that aren't noticeable individually, but could contribute to the game running at a lower FPS than it should, and "big" lag spikes that are more visible (>70ms).

Basically the server times how long it takes from sending a response, to getting back the next set of inputs for that user. Note that even testing locally I was getting about ~18ms when ideally the target is 16.66ms.

In the future it should be possible to detect when users across the server are collectively lagging (most likely meaning a network issue close to the server) and provide both network health metrics for users and the server. The server could nudge users to use a specific fake ping.

This will all take more experimentation but at least this is more useful than the current command. The new version is enabled by default and can be disabled by setting server.improvedLagstatEnabled = false in conf/emulinker.config.

@hopskipnfall hopskipnfall merged commit 011e95b into master Jun 21, 2022
@hopskipnfall hopskipnfall deleted the investigation branch June 21, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant