Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More coroutines cleanup #50

Merged
merged 5 commits into from
Jul 31, 2022
Merged

More coroutines cleanup #50

merged 5 commits into from
Jul 31, 2022

Conversation

hopskipnfall
Copy link
Owner

@hopskipnfall hopskipnfall commented Jul 31, 2022

Primary changes:

  • Uses a buffered Channel instead of a BlockingQueue which should improve resource usage for coroutines a lot
  • Don't launch request handlers asynchronously. This would be nice but I don't think it's necessary or particularly helpful for us.
  • Better logging and cleanup logic. Hopefully this gets rid of some orphaned coroutines.
  • Remove some unused code.
  • Sets the number of Dispatchers.IO coroutine handlers to 1K.

@hopskipnfall hopskipnfall merged commit 9e39f30 into master Jul 31, 2022
@hopskipnfall hopskipnfall deleted the fix-coroutines branch July 31, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant