Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kotlin version, remove some sources of lag #70

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Conversation

hopskipnfall
Copy link
Owner

@hopskipnfall hopskipnfall commented Apr 22, 2023

Several sources of lag removed:

  • Switch to using Timer instead of spinning up a coroutine with a delay() to avoid counting towards coroutine parallelism

  • Bring back Channels for more optimal message handling

  • Properly close both the KailleraUserImpl and V086Controller coroutines which were being left before

  • Fix a race condition where V086Controller.close() was not being called

  • Stop creating a new SelectorManager every time. Apparently the constructor spins up a new long-running coroutine every time.

  • Fix a bug where freed ports were not being made available again.

There is some lag when a user logs out of the server, I'm not sure what causes this yet.

@hopskipnfall hopskipnfall merged commit f191a65 into master Apr 24, 2023
@hopskipnfall hopskipnfall deleted the fix-lag branch April 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant