Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] GitHub signature header #19

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Conversation

amiranagram
Copy link
Contributor

@amiranagram amiranagram commented Feb 13, 2023

This PR fixes the GitHub Webhooks signature header. Additionally, value of the signature starts at char index 7 since the value looks like sha256=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

@ninjaparade
Copy link

@hotmeteor LGTM, 👍

@hotmeteor
Copy link
Owner

pls fix tests

@ninjaparade
Copy link

@amiranagram wtf dude. Tests are failing. image

@amiranagram
Copy link
Contributor Author

Fixed @hotmeteor 🫡

@hotmeteor hotmeteor merged commit 864708c into hotmeteor:main Feb 21, 2023
@hotmeteor
Copy link
Owner

@amiranagram Athankya

@amiranagram amiranagram deleted the fix-gh-header branch February 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants