fix: VisitableView NavigationBar glitch #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing this bug on the demo app made me a bit nervous about the state of hotwire native, so it'd be nice to fix this. I can't comment on the fix in this PR, but fixing the demo app at a minimum would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I believe this is fixing the NavigationBar glitches described in hotwired/turbo-ios#196.
It’s still not perfect when using large titles but otherwise it seems to do the trick.
This PR is just changing the way we insert Subviews in the VisitableView.swift file to make sure they are always inserted the way we want.