Code

Async javascript take 2#29

Code

Merged

joemasilotti merged 29 commits intomainhotwired/strada-ios:mainfrom async-javascript-take-2hotwired/strada-ios:async-javascript-take-2Copy head branch name to clipboardMar 1, 2024

+452-173

Commits

Commits on Nov 17, 2023

• Use a private encoder to compare messages, if needed

  olivaresf

  committed
  8af3967

  Copy full SHA for 8af3967

Commits on Dec 7, 2023

• Remove not necessary encoder and simplify equality function.

  svara

  committed
  e3c4ae8

  Copy full SHA for e3c4ae8

• Convert all JavaScript calls to async functions

  joemasilotti

  committed
  bdafa3f

  Copy full SHA for bdafa3f

Commits on Dec 10, 2023

• evaluateJavaScript must be called from main thread

  joemasilotti

  committed
  8b4e7f7

  Copy full SHA for 8b4e7f7

• Only import public API when testing public API

  joemasilotti

  committed
  28dd478

  Copy full SHA for 28dd478

Commits on Feb 26, 2024

• Ignore .swiftpm directory

  joemasilotti

  committed
  8c6872a

  Copy full SHA for 8c6872a

• Expose error entirely up stack

  joemasilotti

  committed
  5c7b8b5

  Copy full SHA for 5c7b8b5

• Ignore xcuserdata

  joemasilotti

  committed
  77ea025

  Copy full SHA for 77ea025

• Expose non-async functions to public API

  joemasilotti

  committed
  2a9aa02

  Copy full SHA for 2a9aa02

Commits on Feb 27, 2024

• Return non optional value from evaluate(javaScript: String).

  svara

  committed
  52de2a3

  Copy full SHA for 52de2a3

• Remove obsolete completion handler.

  svara

  committed
  e9ce397

  Copy full SHA for e9ce397

• Fix failing BridgeTests.

  svara

  committed
  36f9b17

  Copy full SHA for 36f9b17

• Update BridgeDelegateSpy to conform to BridgingDelegate protocol.

  svara

  committed
  b2fbbfa

  Copy full SHA for b2fbbfa

• Increase expectations timeout interval to 5s.

  svara

  committed
  814213a

  Copy full SHA for 814213a

• Merge pull request #30 from hotwired/async-javascript-take-2-feedback

  Show description for 9cee80f
  joemasilotti

  authored
  9cee80f

  Copy full SHA for 9cee80f

• Improve reliability of flaky tests

  joemasilotti

  committed
  63ca1f0

  Copy full SHA for 63ca1f0

• Completion blocks and no more flaky tests!

  joemasilotti

  committed
  3b083b0

  Copy full SHA for 3b083b0

Commits on Feb 28, 2024

• Add all missing non async versions of reply(to:,with:).

  svara

  committed
  64b17d7

  Copy full SHA for 64b17d7

• Add tests for non async version of reply(to:, with:).`

  svara

  committed
  86ea6f5

  Copy full SHA for 86ea6f5

• Merge pull request #31 from hotwired/async-javascript-take-2-replies

  Show description for cb3cdb3
  joemasilotti

  authored
  cb3cdb3

  Copy full SHA for cb3cdb3

• Make BridgeComponent run on main thread by adopting @mainactor attribute.

  svara

  committed
  390aad4

  Copy full SHA for 390aad4

• Make BridgeDelegate run on main thread by adopting @mainactor attribute.

  svara

  committed
  5d58ad4

  Copy full SHA for 5d58ad4

• Make Bridge run on main thread by adopting @mainactor attribute. Fix a crash when using evaluateJavaScript function.

  svara

  committed
  2364983

  Copy full SHA for 2364983

• Update tests to run on @mainactor.

  svara

  committed
  894a8f1

  Copy full SHA for 894a8f1

Commits on Feb 29, 2024

• Don't dispatch script messages in an async context.

  svara

  committed
  e83e7b4

  Copy full SHA for e83e7b4

• Move expectation timeout interval to its own file.

  svara

  committed
  454d6c0

  Copy full SHA for 454d6c0

• Remove @mainactor attribute from the Bridge and add it to relevant functions only.

  svara

  committed
  5d1cffb

  Copy full SHA for 5d1cffb

Commits on Mar 1, 2024

• Merge branch 'async-javascript-take-2' into thread-safety

  joemasilotti

  authored
  40b3561

  Copy full SHA for 40b3561

• Merge branch 'thread-safety' into async-javascript-take-2

  joemasilotti

  committed
  5ef73bc

  Copy full SHA for 5ef73bc