Fix tests #9
Merged
Fix tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ballista
datafusion
documentation
yjshen
commented
Sep 26, 2021
| } | ||
| } | ||
| let actual = execute(&mut ctx, sql).await; | ||
| let expected = vec![vec![""]; 100]; |
There was a problem hiding this comment.
cast string to Int32 is possible in arrow2, cast failure will result in NULL
https://github.com/jorgecarleitao/arrow2/blob/main/src/compute/cast/mod.rs#L129
| assert!(!arrays.is_empty()); | ||
| let first = arrays[0]; | ||
| assert!(arrays.iter().all(|x| x.len() == first.len())); | ||
| assert!(arrays.iter().all(|x| x.data_type() == first.data_type())); | ||
|
|
||
| let size = arrays.len(); | ||
|
|
||
| let values = concat::concatenate(arrays)?; |
There was a problem hiding this comment.
array_array is to zip elements at the same index for each array into a FixedSizeArray, therefore not identical to concatenate that chain all arrays end to end.
| @@ -441,7 +441,7 @@ impl ExecutionPlan for CsvExec { | |||
| }); | |||
|
|
|||
| Ok(Box::pin(CsvStream::new( | |||
| self.schema.clone(), | |||
| self.projected_schema.clone(), | |||
There was a problem hiding this comment.
The cause for failed tests csv_query_window_with_empty_over and csv_query_window_with_order_by. due to wrong schema provided.
|
almost there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only flaky test remains:
csv_query_window_with_partition_by.