Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift '--target' argument to the right of the 'test' command #12

Closed
wants to merge 4 commits into from

Conversation

mateocabanal
Copy link

I have a library that requires tests to run sequentially. When using this action, I'd add -- --test-threads=1 to the args section. Sadly, this didn't work. After some digging, I noticed the --target argument is appended to the user args. Instead, I have prepended the --target argument.

@autarch
Copy link
Member

autarch commented Jan 27, 2024

Hi Mateo,

Thanks for this. Is there any chance you'd be up for adding a test for this? I'm not sure exactly how you might do this. We'd need some sort of argument that breaks in this position and is necessary for the project in test-project to compile or test properly.

@mateocabanal
Copy link
Author

Yes I'd love to help. I'll try and make the tests pass. I should've checked before publishing a PR

@autarch
Copy link
Member

autarch commented Jan 28, 2024

Yes I'd love to help. I'll try and make the tests pass. I should've checked before publishing a PR

The test failures mostly don't come from your change. I fixed the issues so you should rebase off the v0 branch. The linting failure is from your change, however.

@mateocabanal
Copy link
Author

All tests now pass! The lint failed due to an extra whitespice I accidentally added. Should be good to go now!

@autarch
Copy link
Member

autarch commented Feb 1, 2024

Hi @mateocabanal,

Thanks for fixing the linting issue. But what I was saying earlier is that this also needs some actual tests:

Is there any chance you'd be up for adding a test for this? I'm not sure exactly how you might do this. We'd need some sort of argument that breaks in this position and is necessary for the project in test-project to compile or test properly.

@autarch
Copy link
Member

autarch commented Nov 18, 2024

This was fixed in v0.0.16.

@autarch autarch closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants