Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: bench option #32

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Add: bench option #32

merged 1 commit into from
Nov 23, 2024

Conversation

RaulTrombin
Copy link
Contributor

@RaulTrombin RaulTrombin commented Nov 23, 2024

Allow users to compile and deploy the binary for benchmarking tests. From: issue 31

Use:

 - name: Cross-compile benchmark
        uses: RaulTrombin/actions-rust-cross@add_bench
        with:
          command: bench
          target: ${{ matrix.TARGET }}
          args: "--no-run"

image

@autarch
Copy link
Member

autarch commented Nov 23, 2024

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your fork, I can do my fiddling, then force push to your fork and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

@autarch
Copy link
Member

autarch commented Nov 23, 2024

I just pushed directly to the PR branch. I didn't need access to your forked project. This is the default for PRs, though you can disable it.

@RaulTrombin
Copy link
Contributor Author

I just pushed directly to the PR branch. I didn't need access to your forked project. This is the default for PRs, though you can disable it.

I was able to run with rust stable if use criterion, 6362a68

but still have the same issue for these 3 targets with faillure:
freeBSB, netBSB and aarch64-windows.

They build but can't execute, with arg='no-run' all targets are Ok.

@RaulTrombin
Copy link
Contributor Author

oh, or add on test.yaml:
if: ${{ matrix.platform.can_test }} for bench test.

@autarch autarch force-pushed the add_bench branch 2 times, most recently from 222042b to af6e54a Compare November 23, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants