Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero-length files can be installed from zip archives if a non-file is accidentally matched #88

Closed
fiadliel opened this issue Jan 17, 2025 · 1 comment
Closed

Zero-length files can be installed from zip archives if a non-file is accidentally matched #88

fiadliel opened this issue Jan 17, 2025 · 1 comment

Comments

@fiadliel
Copy link
Contributor

It is possible for a Zip archive to contain both files and directories/symlinks which match the executable name. The current code does not check for this.

If a non-file is found first, the result is confusing for the user, as installation apparently succeeds, but an empty file is installed.
This was referenced Jan 17, 2025
Closed
Closed
@autarch
Copy link
Member

autarch commented Jan 18, 2025

This is fixed in v0.4.1.

@autarch autarch closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Look for first matching file which is a _file_ in zip archive. fiadliel/ubi
2 participants
@autarch @fiadliel