Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for first matching file which is a _file_ in zip archive. #89

Closed
wants to merge 1 commit into from

Conversation

fiadliel
Copy link
Contributor

It is possible that the requested path in the zip can be found as a file, in addition to directory/symlink. The outcome if we don't filter by file type is confusing for the user, as the install can appear to succeed, but the result is an empty file.

Fixes: #88

It is possible that the requested path in the zip can be found as a
file, in addition to directory/symlink. The outcome if we don't
filter by file type is confusing for the user, as the install
can appear to succeed, but the result is an empty file.
@autarch
Copy link
Member

autarch commented Jan 18, 2025

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your PR branch (which is the default when you make a PR), I can do my fiddling, then force push to your PR branch and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your PR branch. Note that this will not work if the PR branch is named master. GitHub doesn't allow me to push to the default branch of your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

@fiadliel
Copy link
Contributor Author

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Sounds like it's less effort all round to go with option 1, and I don't mind missing the attribution.

Thanks again for your contribution!

🙇
Thanks for the software!

@autarch
Copy link
Member

autarch commented Jan 18, 2025

Actually, option 1 is just as easy. I only ask because some people may not realize that I can push to their fork's branch.

@autarch
Copy link
Member

autarch commented Jan 18, 2025

Err, sorry option 2 is just as easy.

@autarch
Copy link
Member

autarch commented Jan 18, 2025

I merged this from the CLI. Thanks!

@autarch autarch closed this Jan 18, 2025
@autarch
Copy link
Member

autarch commented Jan 18, 2025

This is released in v0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Zero-length files can be installed from zip archives if a non-file is accidentally matched
2 participants