Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact support for pyz package #85

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

itochan
Copy link
Contributor

@itochan itochan commented Jan 10, 2025

I have added support for the .pyz format for pypa/pipx.
.pyz is a Python zip archive, but since it can be executed without extracting the zip, it works by simply copying the file. https://docs.python.org/3.13/library/zipapp.html

@autarch
Copy link
Member

autarch commented Jan 11, 2025

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your PR branch (which is the default when you make a PR), I can do my fiddling, then force push to your PR branch and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your PR branch. Note that this will not work if the PR branch is named master. GitHub doesn't allow me to push to the default branch of your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

@itochan
Copy link
Contributor Author

itochan commented Jan 12, 2025

Thank you. The changes are minor, so either option is fine with me.
If option 1 is the default, please work with it.

@autarch autarch merged commit 9ddbf38 into houseabsolute:master Jan 12, 2025
30 checks passed
@autarch
Copy link
Member

autarch commented Jan 12, 2025

I merged this with some tweaks. Thanks!

autarch added a commit that referenced this pull request Jan 18, 2025
@autarch
Copy link
Member

autarch commented Jan 18, 2025

This is released in v0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants