-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated some CLI functionality #43
Conversation
962c6b9
to
33e6869
Compare
@@ -329,6 +336,86 @@ def tableau_authentication(args): | |||
return t | |||
|
|||
|
|||
def set_datasource_connection_args(args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This basically follows the same pattern as the tableau_authentication
method above, and is similar to the connection_settings
method from the deleted connection.py
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I can test this later. Let's try to do all that merge history stuff and then move forward.
I don't have strong feelings about this being in a separate file or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks Jay! :)
818b372
to
a11e990
Compare
a11e990
to
df2087c
Compare
@JustinGrilli I'm trying to troubleshoot the weird PR thing. Can you merge this in? That feels like it might make the comparison simpler but perhaps I'm wrong 😮💨 |
@JustinGrilli could you re-run the CI job on this branch? I'm confused as to why this would suddenly fail. If you re-run the CI job here that will let us know if the issue is the other branches OR if it's something in the CI flow from imports/versions etc. When I google the errors on the other branchs I'm getting package version and pytest version issues. This is an old comment but perhaps it;s relevant pytest-dev/pytest-runner#49 (comment) |
Yeah I will merge this in. Once I merge it, we should see CI run on the refactor-to-use-restapi PR |
Changes
connection
CLI command into aconnection
argument groupconnection
CLI command logic todatasource
andserver_operate
enforce_connection
with theconnection
args to update the connection in the local datasourceconn_user
andconn_pw
when calling--publish datasource
to embed creds for the connection when publishingembed_connection
withconnection
args to embed connection creds for a datasource onlineembed_connection
callserver_operate --publish
, to open the datasource's URL in the browser once published (Like it would when publishing from Tableau Desktop)server_operate
test_tableau_utilities.py
--version
argument to the CLI, which will reference the version of the installed packagereadme
for connection changesample_settings.yaml
and moved to top level folder.cli.py
help comments.--debugging_logs
is provided, it will warn the user.Notes to reviewer
connection
betweendatasource
andserver_operate
is because:Tests
After installing
tableau_utilities
with these changes:tableau_utilities --version
tableau_utilities -d -l online -n Jobs -pn "Official Datasources - Business" -tds datasource --enforce_connection
tableau_utilities -d -n Jobs -pn "Official Datasources - Business" --file_path Jobs.tdsx server_operate --publish datasource