Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies in v1.3.0 release #12

Closed
OldSneerJaw opened this issue Oct 5, 2022 · 5 comments · Fixed by #14
Closed

Missing dependencies in v1.3.0 release #12

OldSneerJaw opened this issue Oct 5, 2022 · 5 comments · Fixed by #14

Comments

@OldSneerJaw
Copy link
Contributor

When using the v1.3.0 release in a workflow, I get the following error:

internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module '@actions/core'
Require stack:
- /home/runner/work/_actions/isbang/compose-action/v1.3.0/main.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/runner/work/_actions/isbang/compose-action/v1.3.0/main.js:1:14)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/runner/work/_actions/isbang/compose-action/v1.3.0/main.js' ]
}

I believe the @actions/core, @actions/github and docker-compose packages should be moved out of package.json's devDependencies section and into the dependencies section so they are available at runtime.

isbang pushed a commit that referenced this issue Oct 6, 2022
Moves packages that are needed at runtime into `package.json`'s `dependencies` section.
@isbang
Copy link
Collaborator

isbang commented Oct 6, 2022

@OldSneerJaw Could you please check if this issue has been fixed by v1.3.1?

@OldSneerJaw
Copy link
Contributor Author

@isbang No luck. After skimming the GitHub Actions docs, it appears you'll have to either commit the node_modules directory to the repo or, ideally, use @vercel/ncc.

@isbang
Copy link
Collaborator

isbang commented Oct 7, 2022

Let me revert abbea89 commit. I hope this will fix the problem.

@isbang isbang closed this as completed in #14 Oct 7, 2022
@isbang isbang reopened this Oct 7, 2022
@isbang
Copy link
Collaborator

isbang commented Oct 7, 2022

@OldSneerJaw Hope v1.3.2 fixed this problem. How is it now?

@OldSneerJaw
Copy link
Contributor Author

It works again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants