Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve messages to Smalltalk in a more compatible way #114

Closed
fniephaus opened this issue May 29, 2020 · 0 comments
Closed

Resolve messages to Smalltalk in a more compatible way #114

fniephaus opened this issue May 29, 2020 · 0 comments

Comments

@fniephaus
Copy link
Member

Currently, all occurrences of _ are simply replaced with : when a message is sent through interop to a Smalltalk object. This, however, implies it's always necessary that an identifier ends with _ if arguments are supplied (example: SmalltalkArrayClass.with_(42)). We should make message resolution a bit smarter because it's clear that the Smalltalk selector needs to end with : with arguments are supplied. This way, it'd be possible to do SmalltalkArrayClass.with(42), which will effectively be the same as SmalltalkArrayClass.with_(42).

@fniephaus fniephaus self-assigned this May 29, 2020
fniephaus added a commit that referenced this issue May 29, 2020
- Add test for #114
- Refactor ForeignObjectTest and introduce jsEval:
- Add descriptions to test(JS)MetadataAPIs
fniephaus added a commit that referenced this issue May 29, 2020
# Example
```
color -> #color
color(arg) -> #color:
color_(arg) -> #color:
```

Closes #114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant