-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Squeak Test Execution #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of test parameterization, all subordinate test cases are now known to MX, which can now take care of test name logging and measuring runtime (given --enable-timing).
Using a future should make runTestCase much easier to follow, and the test result construction is now obvious. It should be a little less resource consuming since the threads from the default pool are reused rather than creating a new one for every test case ran.
Codecov Report
@@ Coverage Diff @@
## dev #14 +/- ##
============================================
+ Coverage 51.95% 52.72% +0.76%
- Complexity 2432 2513 +81
============================================
Files 182 188 +6
Lines 16189 16645 +456
Branches 2265 2315 +50
============================================
+ Hits 8411 8776 +365
- Misses 6918 6992 +74
- Partials 860 877 +17
Continue to review full report at Codecov.
|
Thanks, will have a look soon. Happy holidays! |
Thanks a lot, this looks good! I've merged it in as is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major selling points:
The Squeak test class is chosen via system property:
I've come to the conclusion that the Travis build log visualization is unreliable. I cannot explain artifacts like these:
Given that the raw build logs look OK to me.
I cannot meet the goals for coverage - I added test code for handling test case failures, which are naturally not part of a successful build.