Improve TickEventLoop() #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luminosuslight
requested changes
Jan 30, 2018
src/node.cc
Outdated
| @@ -4803,18 +4803,20 @@ inline static bool TickEventLoop(Environment & env) { | |||
| bool more = false; | |||
There was a problem hiding this comment.
more is not used anymore, right?
src/node.cc
Outdated
| more = uv_loop_alive(env.event_loop()); | ||
| if (more) | ||
| return more; | ||
| if (uv_loop_alive(env.event_loop())) |
There was a problem hiding this comment.
We should either add curly braces around the return statement here or remove them in line 4806 to be consistent.
|
Updated. @luminosuslight feel free to approve and merge! |
luminosuslight
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce early check for uv_loop_alive() and small refactoring
From what I was able to find, this was the only necessary change to our TickEventLoop() function. See #27 for an explanation why I think the change was necessary.
fixes #27