Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune LSP completions resolve capabilities to be more immediate #77

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Dec 10, 2024

Follow-up of #75
Closes #72
Part of rust-lang/rust-analyzer#18504

As requested in #75 (comment) , I've used the original PR's change, removed filterText, sortText and restored documentation field.

On top of that, I've added command to be resolved, as additionalTextEdits are resolved anyway and its a quite rare thing to use.
From https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem

/**
 * An optional command that is executed *after* inserting this completion.
 * *Note* that additional modifications to the current document should be
 * described with the additionalTextEdits-property.
 */
command?: Command;

lua/cmp_nvim_lsp/init.lua Outdated Show resolved Hide resolved
@hrsh7th
Copy link
Owner

hrsh7th commented Dec 10, 2024

I appreciate your patience.
Thank you.

@hrsh7th hrsh7th merged commit 99290b3 into hrsh7th:main Dec 10, 2024
@SomeoneToIgnore SomeoneToIgnore deleted the better-resolve-support branch December 10, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textEdit completion item property is not resolved lazily
2 participants