DXT5: Fix decoding of alpha channel for textures with a non-mod-4 width. #18554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still haven't done full proper tests of dimensions with DXT, including bufw. Wasn't sure if the lower resolutions were actually "supported". -[Unknown] |
|
They kind of have to be for the smallest mipmaps, and are on every other GPU that supports DXT so seems likely - but indeed, a test would be best. But the fact that games use 2x32 textures also confirms it, really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to step through the DXT5 decoder to see it.. Silly logical mistake.
Fixes #18108