Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of cases where we forgot to check for CHD files #18924

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

hrydgard
Copy link
Owner

Should fix some issues like possibly #18919 .

@hrydgard hrydgard added this to the v1.18.0 milestone Mar 12, 2024
@@ -502,7 +502,7 @@ bool System_MakeRequest(SystemRequestType type, int requestId, const std::string
std::vector<std::string> supportedExtensions = {};
switch ((BrowseFileType)param3) {
case BrowseFileType::BOOTABLE:
supportedExtensions = { ".cso", ".bin", ".iso", ".elf", ".pbp", ".zip" };
supportedExtensions = { ".chd", ".cso", ".bin", ".iso", ".elf", ".pbp", ".zip" };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering why .prx extension can't be found in this list :) since prx files can be run on PPSSPP too (ie. sample files from PSPSDK)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was probably just forgotten when the list was created. I'll add it.

@hrydgard hrydgard merged commit 0b4dfb8 into master Mar 13, 2024
18 checks passed
@hrydgard hrydgard deleted the chd-detection-fixes branch March 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants