Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRJit: If we're in "JIT using IR" mode, don't accidentally optimize for the interpreter. #19268

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jun 11, 2024

We generate some interpreter-only IR instructions in this case, which the IR JITs can't handle.

Fixes #19266

@hrydgard hrydgard added the IRInterpreter Occurs with IR Interpreter but not with another CPU backend. label Jun 11, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone Jun 11, 2024
@hrydgard hrydgard merged commit c739599 into master Jun 11, 2024
18 checks passed
@hrydgard hrydgard deleted the fix-ir-jits branch June 11, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRInterpreter Occurs with IR Interpreter but not with another CPU backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT/Dynarec crash upon load on RISC-V
1 participant