Final Fantasy I (ULES00986): Minor graphical regression present on the World Map in PPSSPP since v0.9.5-16-g1347c3b

[solarmystic]

Issue is as stated in the title. Responsible commit found via bisecting is v0.9.5-1-g5de7bb2 5de7bb2 merged into master with v0.9.5-16-g1347c3b 1347c3b by @hrydgard

Note the black squares on the world map along the coastline:-

Last unaffected revision is v0.9.5-12-g3403928 3403928

Issue reproduction:

1. Run FFI on any 32 or 64bit PPSSPP build from v0.9.5-16-g1347c3b onwards using default settings.
2. Load a savegame and head to the world map by exiting the town. Use this savefile for easy reproduction:- http://www.mediafire.com/?i7pm7jzbsa2uoc7
3. You will then see black squares on the coastline.

Tested on the following machine:

[daniel229]

Breaks xBRZ scaling as well

[unknownbrackets]

In FF1's case, it seems like w is less than bufw, but that shouldn't really be a problem?

For texture scaling, maybe we should just turn it off. It seems like the scaler expects it be aligned to width already.

-[Unknown]

[hrydgard]

The texture scaling problem should be fixed (turned it off when scaling).

The black squares confuse me though...

[thedax]

How about this one? Is this still occurring?

[solarmystic]

Still happening on the latest master at the moment.

[unknownbrackets]

Strange that this hasn't popped up in other games (except with texture scaling)...

-[Unknown]

[unknownbrackets]

If I force the texture cache to redo the texture every frame, it only happens once every 8 frames. But, if I use "step tex", then like #2917 it doesn't reproduce. Weird...

-[Unknown]

[unknownbrackets]

Finally found it, arg...

-[Unknown]