Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scePowerSetClockFrequency timing by JPCSPTrace #8960

Merged
merged 3 commits into from
Sep 6, 2016

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Sep 6, 2016

Fix #4523 Fix #6813

@hrydgard
Copy link
Owner

hrydgard commented Sep 6, 2016

You're specifying 150us but the logs seemed to indicate 150ms.

Though, if this works, I guess that's alright... Waiting as long as 150ms seems dangerous anyway.

Can you try this again with 150000 instead of 150? If that works just as well, let's go with that, otherwise this is fine.

@sum2012
Copy link
Collaborator Author

sum2012 commented Sep 6, 2016

Yes, 150000 work
Fix #6813 too

@hrydgard
Copy link
Owner

hrydgard commented Sep 6, 2016

Great!

I think you should also change the INFO_LOG back to DEBUG_LOG, then merge :)

@sum2012
Copy link
Collaborator Author

sum2012 commented Sep 6, 2016

Can leave scePowerSetBusClockFrequency INFO log ?
We might need to fix the timing,

@hrydgard
Copy link
Owner

hrydgard commented Sep 6, 2016

Hm, you're right that there might be more to do here. We can keep them all for a while.

@hrydgard hrydgard merged commit ad0167c into hrydgard:master Sep 6, 2016
@unknownbrackets
Copy link
Collaborator

Seems like a good candidate for a release notes entry in v1.3.0, this game has never worked afaik.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Sep 6, 2016

Yeah, agreed.

@sum2012 sum2012 deleted the power-minor branch September 6, 2016 19:47
@sum2012
Copy link
Collaborator Author

sum2012 commented Sep 6, 2016

I think that we can use this method to fix sceUtility timing,
At least 2 games effect in timing.

@unknownbrackets
Copy link
Collaborator

I think we may end up needing to use a fake HLE thread for that. We've already timed it, but the timing is different between games because of other thread behavior, iirc.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants