Vulkan fragment shaders: Don't opportunistically emit "layout (early_fragment_tests) in" #15673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fragment_tests)" The purpose of this is not really for optimization, it's to get a specific behavior that we really don't care about. Drivers are pretty good at getting this potential performance improvement automatically if it's possible without changing the output. git blame says I added it, heh. Don't think it'll make much difference one way or another, though, but trying to reduce complexity.
|
I do think I added it explicitly in #11197. Was trying to explicitly enable the behavior described by the spec which uses "if and only if" language. Hoped it would mean less of these bugs, but clearly hasn't helped, so I don't mind seeing it go. -[Unknown] |
unknownbrackets
approved these changes
Jul 11, 2022
|
Ah, guess I got a false hit to my shader gen refactoring with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this feature is not really for optimization, it's to get a specific behavior that we really don't care about. Drivers are pretty good at getting this potential performance improvement automatically if it's possible without changing the output.
git blame says I originally added it, heh.
Note that this is never activated in the situation talked about in #15016 where discard gets ignored for stencil writes (discard comes from the alpha/color tests), so this was not what broke that.
Don't think it'll make much difference one way or another, though, just trying to reduce complexity.