Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the "Retain changed textures" option into a compat.ini option. #16346

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Change the "Retain changed textures" option into a compat.ini option. #16346

merged 3 commits into from
Nov 6, 2022

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Nov 6, 2022 •
edited
Loading

This option benefits so few games and can hurt others, so that it's better that we specifically enable it for known cases like Popolocrois.

See #16339 and #8171

@hrydgard
Change the "Retain changed textures" option into a compat.ini option.
95cb358 
This option benefits so few games and can hurt others, so that it's
better that we specifically enable it for known cases like Popolocrois.
@hrydgard hrydgard added User Interface PPSSPP's own user interface / UX Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. labels Nov 6, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Nov 6, 2022
@unknownbrackets
Copy link
Collaborator

#7806 notes a game that might be helped, maybe #15251, #10418 as well. I feel like there was some other, but can't find it from a few quick searches.

-[Unknown]

unknownbrackets
unknownbrackets approved these changes Nov 6, 2022
View reviewed changes
libretro/libretro.cpp Show resolved Hide resolved
@unknownbrackets unknownbrackets merged commit 31cb3a8 into master Nov 6, 2022
@unknownbrackets unknownbrackets deleted the remove-retain-changed-textures-setting branch November 6, 2022 18:18
@ghost ghost mentioned this pull request Dec 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknownbrackets unknownbrackets unknownbrackets approved these changes

Assignees
No one assigned
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. User Interface PPSSPP's own user interface / UX
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hrydgard @unknownbrackets