Rebased WIP: Infrastructure: sceNetInet and sceNetResolver support #19807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AdamN <[email protected]>
…mes impl and begin converting ERROR_LOGS into hleLogError + ensuring last error is set.
Merged
2 tasks
|
The way I see it the whole network infrastructure code should be done using the (standalone) Asio C++ library as the network backend. It's robust, well known, and supports lots of platforms, so we wouldn't need to write platform-dependent code. It's also worth noting the current C++ networking technical specification is based on the Asio C++ networking library. |
|
That might indeed be a good idea. However I'm not very good at networking and I've never used asio, so switching over isn't gonna be the first priority. But, none of the changes I'm planning to make is likely to make it harder to switch either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #18578 by @JustAWhiteBloodCell, but rebased on the latest codebase.
No clue if it works, but figure it might be a good idea to get it in, as the way it currently is, nobody can work on it. See the other issue for more reasoning about which infrastructure PR to merge.