Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix Outrun 2006 infrastructure #19879

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Attempt to fix Outrun 2006 infrastructure #19879

merged 3 commits into from
Jan 17, 2025

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 16, 2025

However, not getting it to work just yet.. Running ULES00262.

This refactors away an unnecessary wrapper class from sceNetResolver because it got in the way. This was moved to #19880

I put the DNS 45.7.228.197 in infra.json for the game ID. It ends up asking it for outrun2.stun.us.demonware.net, and in response it gets 34.118.10.198 . Then, further access to this seems to time out when registering an account (the game has you enter user/pass before connecting).. Not sure what's going on.

Should try with the old fork, I guess... EDIT: Apparently the server isn't working. Oh well.

See #

@anr2me
Copy link
Collaborator

anr2me commented Jan 17, 2025

May be 34.118.10.198 is an official server?

As i remembered there is private server for outrun2.stun.us.demonware.net in the google doc/sheet you posted not long ago, the one showing a list of PSRewired games (Outrun 2006 servers is at the bottom of the list), i don't remembered where you posted it, either in an issue or PR.

Edit: Here is the doc (found it in my browser history) https://docs.google.com/document/d/1B2BTbs2srlZ32SN8XVpqIm68_0oI4QOYshJvG0npXr0/edit?tab=t.0

TWEAKS Server:

US Outrun 2006: Cost 2 Cost 34.116.176.7 outrun2.stun.us.demonware.net
EU Outrun 2006: Cost 2 Cost 34.116.176.7 outrun2.stun.eu.demonware.net

g_Config.mHostToAlias["socompsp-prod.muis.pdonline.scea.com"] = "67.222.156.250";
SceNetResolver::Init();
return hleLogSuccessInfoI(Log::sceNet, 0);
// TODO: Move this to infra-jns.config! This isn't ok.
Copy link
Collaborator

@anr2me anr2me Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to keep the HostAliases feature for private server developers to override DNS from AutoDNS/server updated infra-dns.json, since they usually use LAN IP during early development.

And with PPSSPP's built-in DNS Resolver, overriding it through system's hosts file won't work anymore, so PPSSPP need to provide a way for them to use their LAN IP (ie. HostsAliases feature)

Then again, they can just run a DNS server (or DNS proxy like AcrylicDNS) on localhost and disable AutoDNS :)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostAliases feature will be kept, however these hardcoded lines right here will be moved to the json.

return hleLogSuccessI(Log::sceNet, 0);
}
// TODO: Ignoring SO_NOSIGPIPE flag to prevent crashing PPSSPP (not sure if PSP has NOSIGPIPE or not tho, defined as 0x1022 on Darwin)
else if (optname == 0x1022) { // PSP_NET_INET_SO_NOSIGPIPE ?
Copy link
Collaborator

@anr2me anr2me Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably replace this raw number with an identifier for easier to replace later if this is wrong, but i'm not sure whether there are games that use this option name or not, just a precaution not to change NOSIGPIPE on the host side.

PS: We might want to use REPORT_ONCE on this value, just in case this value is being used by one of the game i've tested before (i forgot whether i saw this value in the logs or not)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll turn it into a hleLogWarning for now. I don't think turning on signals make sense for any psp game anyway since the PSP doesn't really have unix signals...

@hrydgard
Copy link
Owner Author

Cut down this PR to just the Outrun changes and kept the rest in #19880 .

@hrydgard hrydgard marked this pull request as ready for review January 17, 2025 14:11
@hrydgard hrydgard merged commit 0217038 into master Jan 17, 2025
19 checks passed
@hrydgard hrydgard deleted the more-online-fixes branch January 17, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants