Add some error handling in sceSas, delay sceSasCore() #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Kingdom Hearts bug, hrydgard#2066.
Not sure if this fixes anything, but scheduling issues can be tricky.
This is no longer needed for games I have, and it breaks Final Fantasy Tactics' sound effects. Looking at JPCSP for insight, I saw that it re-enables loops if you set a voice even with a different address (I think?) but that seems strange.
hrydgard
added a commit
that referenced
this pull request
Jun 10, 2013
Add some error handling in sceSas, delay sceSasCore()
|
Oh, I added a commit that reverted the previous (I think wrong) attempt to fix undead VAG loops, which broke nothing I had and fixed Final Fantasy Tactics. -[Unknown] |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per tests, this is what the functions seem to do. Fixes the huge delay in Kingdom Hearts.
Final Fantasy Tactics is still playing weird screwy sound effects, though...
-[Unknown]