Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply offset by 1px for our provided fonts #4320

Merged
merged 1 commit into from
Oct 27, 2013
Merged

Apply offset by 1px for our provided fonts #4320

merged 1 commit into from
Oct 27, 2013

Conversation

dbz400
Copy link
Contributor

@dbz400 dbz400 commented Oct 26, 2013

Trying to detect original PSP fonts here (only jpn0.pgf ) and apply offset by 1px for non original one which is the one we provided in our package

Partially fix #2675

@hrydgard
Copy link
Owner

Can you do the reverse check instead? That is, check for the size (or hash) of our font file instead. That way we won't apply the offset if someone replaces them with their own font of some sort.

@thedax
Copy link
Collaborator

thedax commented Oct 26, 2013

Why not do a SHA-1 hash instead of checking for size? Someone could easily spoof the same size file (not that it's likely, but it's much easier to spoof a blank file/pad a file then it is to fake a SHA-1).

@unknownbrackets
Copy link
Collaborator

This is obviously very hacky... not sure if we're concerned about spoofing, though?

-[Unknown]

@hrydgard
Copy link
Owner

Spoofing sounds like a pretty remote concern.

Not a big fan of the hackiness of this either, but checking for and "fixing" our own font files is the reasonable way, if we're going to do it ....

@dbz400
Copy link
Contributor Author

dbz400 commented Oct 27, 2013

It is bit hacky anyway, at least useful for this time being as fixing our own font files may not be happened so soon .

hrydgard added a commit that referenced this pull request Oct 27, 2013
Apply offset by 1px for our provided fonts
@hrydgard hrydgard merged commit ea05c93 into hrydgard:master Oct 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various issues with Growlanser: Wayfarer of Time (ULUS10593), post v0.8.1-361-gc71ae64 (updated)
4 participants