Skip to content
This repository has been archived by the owner on Apr 15, 2018. It is now read-only.

Add close() method to Coordination for resource cleanup #167

Open
franbh opened this issue Nov 14, 2017 · 0 comments
Open

Add close() method to Coordination for resource cleanup #167

franbh opened this issue Nov 14, 2017 · 0 comments

Comments

@franbh
Copy link

franbh commented Nov 14, 2017

Hi, because of Tecsisa/constructr-consul#49, I think it is necessary to add a close() method to Coordination, in order to perform resource release on system shutdown in a clean, elegant way. An example of such resource cleanup would be destroying the Consul session instead of just relying on TTL.

close() would be invoked by the ConstructrMachine implementation of the onTermination hook.

If this is not useful to etcd, we can just have a dummy implementation of close(), returning something like Future.successful(Done).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant