You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 15, 2018. It is now read-only.
Hi, because of Tecsisa/constructr-consul#49, I think it is necessary to add a close() method to Coordination, in order to perform resource release on system shutdown in a clean, elegant way. An example of such resource cleanup would be destroying the Consul session instead of just relying on TTL.
close() would be invoked by the ConstructrMachine implementation of the onTermination hook.
If this is not useful to etcd, we can just have a dummy implementation of close(), returning something like Future.successful(Done).
The text was updated successfully, but these errors were encountered:
franbh
pushed a commit
to Tecsisa/constructr
that referenced
this issue
Nov 15, 2017
Hi, because of Tecsisa/constructr-consul#49, I think it is necessary to add a
close()
method toCoordination
, in order to perform resource release on system shutdown in a clean, elegant way. An example of such resource cleanup would be destroying the Consul session instead of just relying on TTL.close()
would be invoked by theConstructrMachine
implementation of theonTermination
hook.If this is not useful to etcd, we can just have a dummy implementation of
close()
, returning something likeFuture.successful(Done)
.The text was updated successfully, but these errors were encountered: