This repository has been archived by the owner on Apr 15, 2018. It is now read-only.
introduce docker-it-scala for etcd tests #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note
commented
Mar 22, 2017
| ) | ||
| ) | ||
|
|
||
| parallelExecution in Global := false |
There was a problem hiding this comment.
The problem was with inter-submodules concurrency. Usually it is that multi nodes tests are run before EtcdCoordinationSpec's afterAll was called. It is not desired because than creating etcd container fails because one is still running (and has not been stopped yet).
It was the easiest fix for that. I am open for any suggestions.
note
commented
Mar 22, 2017
| @@ -18,7 +18,7 @@ lazy val core = | |||
| project | |||
| .enablePlugins(AutomateHeaderPlugin) | |||
| .configs(MultiJvm) | |||
| .dependsOn(coordination,`coordination-etcd` % "test->compile") | |||
| .dependsOn(coordination,`coordination-etcd` % "test->test") | |||
There was a problem hiding this comment.
That's because we use DockerEtcdService also in core. And since DockerEtcdService is defined in coordination-etcd test scope we need this change
|
Thanks for your contribution. Apologies, but I'm currently too busy to review. |
|
Have you considered @testcontainers? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #129