Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packed_simd_2 #58

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Use packed_simd_2 #58

merged 1 commit into from
Oct 9, 2020

Conversation

Gelbpunkt
Copy link
Contributor

This updates packed_simd to 0.3.4, which is sadly only available on the packed_simd_2 crate (more on that at rust-lang/packed_simd#298). It fixes compilation with the simd-accel feature on recent nightly toolchains.

@hsivonen
Copy link
Owner

hsivonen commented Oct 9, 2020

Thanks. What's the purpose of using package = "packed_simd_2" instead of changing the dependency name to packed_simd_2?

@Gelbpunkt
Copy link
Contributor Author

It allows past use statements for packed_simd to work even though the name changed to packed_simd_2. I assume they recommended it in case they get ownership of packed_simd on crates.io again. This way it is only required to change one line instead of all imports in the code files.

If you would like to use packed_simd_2 directly nonetheless, I'll happily update the files, just let me know!

@hsivonen
Copy link
Owner

hsivonen commented Oct 9, 2020

OK. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants