Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot improvements #3

Merged
merged 5 commits into from
Jul 24, 2019
Merged

Plot improvements #3

merged 5 commits into from
Jul 24, 2019

Conversation

breznak
Copy link
Member

@breznak breznak commented Jul 24, 2019 •
edited
Loading

community version of numenta#342

  • makes plots work out of the box (installs plotly requirement)
  • include data in package, otherwise plot was broken with invalid paths
  • additional fixes for plotly API changes (not part of Numenta PR, should be added there too)

breznak added 5 commits July 24, 2019 12:06
@breznak
fix plotly dependency
7959f6c 
required for scripts/plot.py
@breznak
typos
48b6ed6
@breznak
fixing dependency data not installed
0e9c5df
@breznak
update Readme for plot
d6d92de
@breznak
plot: remove deprecated autotick
8e8c931 
the plot was failing due to non-existing argument, just removed
@breznak breznak added the bug Something isn't working label Jul 24, 2019
@breznak breznak self-assigned this Jul 24, 2019
ctrl-z-9000-times
ctrl-z-9000-times approved these changes Jul 24, 2019
View reviewed changes
Copy link
Collaborator

@ctrl-z-9000-times ctrl-z-9000-times left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@breznak breznak merged commit c4d1e20 into master Jul 24, 2019
@breznak breznak deleted the plot_community branch July 24, 2019 13:50
@breznak
Copy link
Member Author

breznak commented Jul 24, 2019

Thank you for reviewing, David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrl-z-9000-times ctrl-z-9000-times ctrl-z-9000-times approved these changes

@Lupino Lupino Awaiting requested review from Lupino

Assignees

@breznak breznak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breznak @ctrl-z-9000-times