Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OpenStruct causes NameError in Rake13.2.0 #6

Conversation

janz93
Copy link
Contributor

@janz93 janz93 commented Oct 10, 2024

resolves #5
Loading of "ostruct" depends on Rake, so we need to explicitly load it and resolve the dependency.
Because Rake does not load "ostruct" since version 13.2.0.
ruby/rake#545

Loading of "ostruct" depends on Rake, so we need to explicitly load it and resolve the dependency.
Because Rake does not load "ostruct" since version 13.2.0.
[ruby/rake#545](ruby/rake#545)
the gem name does not match the gem class name.
Therefore an loading issue can occure.
Bundler has an [option to load](https://bundler.io/v2.5/man/gemfile.5.html#REQUIRE-AS) 
a different class if the gem name differes
@davidray
Copy link

davidray commented Nov 7, 2024

I'd really appreciate it if this one could get released - I need to upgrade rake in my application and am blocked by this.

@janz93
Copy link
Contributor Author

janz93 commented Nov 7, 2024

@davidray Could you clarify what you mean by
| I need to upgrade rake in my application and am blocked by this.

Is this fix blocking your further development of the gem, or is there something else where support might be needed to get this PR released?

@davidray
Copy link

davidray commented Nov 7, 2024

Hi @janz93. Thanks for following up. I'm a customer of the htmlcsstoimage API and I am using this gem in my rails app. I'd like to upgrade rake in my rails app, but when I do it breaks this gem. I am currently running off this branch in production, and that's not really ideal.

Does that help?

@mscoutermarsh
Copy link
Member

Sorry, I missed this. Will work on reviewing and getting it released.

@mscoutermarsh mscoutermarsh merged commit 06f4a85 into htmlcsstoimage:main Nov 7, 2024
1 check passed
@mscoutermarsh
Copy link
Member

New version has been released: https://rubygems.org/gems/htmlcsstoimage-api.

@janz93 Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: uninitialized constant HTMLCSSToImage::OpenStruct
3 participants