Add option to rewrite path in set-cookie headers #1235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures due to #1167 |
|
@swillis12 ill get this merged into my maintenance branch when I re-add backwards compatibility so this is not a breaking change. |
|
I realized this isnt a breaking change, silly me. Thanks for the contribution @swillis12. Cherry picked into maintenance. branch |
|
superceded by #1251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to rewrite the path of a cookie in the set-cookie header, building on top of what was there for #1009. I added some documentation and test cases and am open to feedback. I look forward to having this merged in.
Example usage:
"cookiePathRewrite": "/"This will rewrite cookie paths from
/dummyPathto/. This is useful when using Tomcat and each application is hosted in it's own "context" (which is the war file name), so the path for each cookie is set to the war file name.