-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve individual headers with the same name on responses #1208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
- Coverage 97.28% 96.78% -0.50%
==========================================
Files 67 72 +5
Lines 4235 4637 +402
==========================================
+ Hits 4120 4488 +368
- Misses 115 149 +34
Continue to review full report at Codecov.
|
|
||
response = super().build_response(req, resp) | ||
response.headers = HTTPHeadersDict(getattr(resp, "headers", {})) | ||
return response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking about moving httpie/ssl.py
into httpie/adapters.py
, since it does make sense for all the adapters to be in the same place. WDYT @jakubroztocil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍🏻
Resolves #1207