-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Struct SelectFrom should include full table name #40
Comments
@huandu I'm willing to make a PR to help with this as it's important for our use-case. Which approach do you prefer?
I would personally go with 2, as it can be applied to all queries in the generator and it won't break existing queries |
Thanks for your suggestion, @albertorestifo. I'm thinking of how to design it these days. The ideal solution in my mind is similar to 2 except that the prefix is added only if JOIN is used in |
The commit fb2186e implements solution 2. I still cannot find a way to add prefix only if JOIN is used without ugly magic. Let's go with solution 2 before we have a perfect solution. |
This worked perfectly, many thanks for the speedy solution |
When making joins, it would be useful is the
Struct
added the table name to the fields or if it implemented aSelectFromAs
method.Right now, for example, there is no way of doing this:
This will fail as both the
companies
andcompany_balances
table have acompany_id
field.The text was updated successfully, but these errors were encountered: