Add insert ignore #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plz cr. @huandu |
huandu
requested changes
Nov 10, 2019
struct.go
Outdated
Comment on lines
223
to
224
| //`InsertIgnoreInto` is the Same with `InsertInto`, except for inserting with the existing primary key or unique key. | ||
| //When inserting with the existing primary key or unique key, the db would ignore this operation with no error. |
There was a problem hiding this comment.
Some wording issues. All newly added docs have same issues.
- Leave a blank after every
//. - The comment should start with a definition of this func, e.g. ReplaceIntoForTag creates a new
InsertBuilderforREPLACEwith table name. We need to provide enough information to doc readers. We should not force them to check another func to understand how to use this func. the Same with->similar to(and mind the case please)- The sentence
except for ...is not true. The responsibility of this package is only to build SQL without any execution. We need to tell readers what would happen to the SQL we build, e.g. usingINSERT IGNORE INTOinstead ofINSERT INTO. - As of previous review comment, the sentence
When inserting with ...should be deleted. I believe package users are DB experts and know how to useINSERT IGNORE INTO.
You can communicate with me for doc in person before submitting a new version. It would be more effective for us.
struct.go
Outdated
Comment on lines
351
to
396
| if s.taggedFields == nil { | ||
| return ib | ||
| } | ||
|
|
||
| fields, ok := s.taggedFields[tag] | ||
|
|
||
| if !ok { | ||
| return ib | ||
| } | ||
|
|
||
| vs := make([]reflect.Value, 0, len(value)) | ||
|
|
||
| for _, item := range value { | ||
| v := reflect.ValueOf(item) | ||
| v = dereferencedValue(v) | ||
|
|
||
| if v.Type() == s.structType { | ||
| vs = append(vs, v) | ||
| } | ||
| } | ||
|
|
||
| if len(vs) == 0 { | ||
| return ib | ||
| } | ||
|
|
||
| cols := make([]string, 0, len(fields)) | ||
| values := make([][]interface{}, len(vs)) | ||
|
|
||
| for _, f := range fields { | ||
| cols = append(cols, f) | ||
| name := s.fieldAlias[f] | ||
|
|
||
| for i, v := range vs { | ||
| data := v.FieldByName(name).Interface() | ||
| values[i] = append(values[i], data) | ||
| } | ||
| } | ||
|
|
||
| cols = s.quoteFields(cols) | ||
| ib.Cols(cols...) | ||
|
|
||
| for _, value := range values { | ||
| ib.Values(value...) | ||
| } | ||
|
|
||
| return ib |
|
solved the problems above,and plz cr again @huandu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
REPLACE INTOandINSERT IGNORE INTO.Almost the same with
InsertInto, and easily pass the tests.