Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert ignore support for postgres and sqlite #87

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

zhongr3n
Copy link
Contributor

@zhongr3n zhongr3n commented Sep 14, 2022

Summary

Add insert ignore support for postgres and sqlite.

For pg, this is ON CONFLICT DO NOTHING, for sqlite it's INSERT OR IGNORE

Testing

  • Added new unit tests
  • Tested against local postgres server using this library (changes in another private repo)
  • Manually tested sqlite query on https://sqliteonline.com/

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.063% when pulling fc1e041 on zhongr3n:zhongr3n/fix-insert-ignore into de26a75 on huandu:master.

@huandu
Copy link
Owner

huandu commented Sep 17, 2022

LGTM. Thanks for your contribution!

@huandu huandu merged commit 167e2ad into huandu:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants