Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1076 SageMaker image_uri is now optional #1077

Merged
merged 1 commit into from
Feb 15, 2023
Merged

#1076 SageMaker image_uri is now optional #1077

merged 1 commit into from
Feb 15, 2023

Conversation

dbpprt
Copy link
Contributor

@dbpprt dbpprt commented Feb 15, 2023

Addressing #1076

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 15, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM but would love to have @philschmid have a look as well.

philschmid
philschmid approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix

@sgugger sgugger merged commit 2794753 into huggingface:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@philschmid philschmid philschmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbpprt @HuggingFaceDocBuilderDev @philschmid @sgugger