Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config #1090

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fix config #1090

merged 2 commits into from
Feb 17, 2023

Conversation

muellerzr
Copy link
Collaborator

Closes #1083

Sadly to my knowledge there's not a decent way to test for the CLI use case without running some extensive test-check specific cases inside the config questionnaire logic. I think it'd be worth it later to do so but not right now.

@muellerzr muellerzr added the bug Something isn't working label Feb 17, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 17, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sgugger sgugger merged commit 89b7e36 into main Feb 17, 2023
@sgugger sgugger deleted the config-tests branch February 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterConfig.__init__() got an unexpected keyword argument 'tpu_downcast_bf16'
3 participants