Fix CPU error always being raised #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
pushed a commit
that referenced
this pull request
Mar 13, 2023
* Save state * Revert to old behavior * Fix failing test/update * Remove duplicate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I've discovered a neat behavior in the library, that was "broken" with the State rewrite. With how
Acceleratewill work, if the user definescpu=Falseinitially then goescpu=True, then a value error will be raised and the state will be changed. But ifcpu=Trueis passed first thencpu=False, nothing will change and no error will be raised. The reason for this is simply because its the default and its a way forStateto not override the first choice, so we assume CPU all the time.Also brings back the
ACCELERATE_USE_CPUenv flag, as this was removed in theStaterefactor.This brings back this behavior and adds a test to the
AcceleratorTesterclass.Closes #1174