Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially fix tests #2862

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Potentially fix tests #2862

merged 2 commits into from
Jun 18, 2024

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Jun 17, 2024

What does this PR do?

We've found out who didn't prepare for numpy v2.0.0: wandb :)

Jk it's deepspeed, numpy, and a few more. We'll pin for now sadly 😢

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@muellerzr muellerzr requested a review from SunMarc June 17, 2024 07:26
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ! i guess this is the best solution since there are so many failing tests ;)

@muellerzr
Copy link
Collaborator Author

Merging and we can see what happens. It may not fix this in the end, but we can try

@muellerzr muellerzr merged commit 1f7a79b into main Jun 18, 2024
31 of 36 checks passed
@muellerzr muellerzr deleted the fix-ci branch June 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants