-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS-AMP support (w/o FSDP) #3093
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these issues. Overall, this looks good, I have a couple of comments but no big ones.
Nice benchmarks too, I didn't check all the details, as they're based on the existing ones AFAICT.
5289332
to
519c417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, LGTM. As mentioned internally, I could not test it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the support with Deepspeed ! Nice benchmarks for fp8. Just a small nit
Co-authored-by: Marc Sun <[email protected]>
What does this PR do?
Fixes up the MS-AMP integration to include:
FSDP is unsupported while Azure/MS-AMP#181 is in limbo.
Closes #2143
Closes #2971
Closes #3050
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan @SunMarc