Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tpu): remove nprocs from xla.spawn #3324

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

tengomucho
Copy link
Contributor

What does this PR do?

This should fix some issues that have been hit by the torch xla team when testing in CI.

Fixes #3304

@muellerzr
Also CC @tengyifei for visibility.

This parameter will cause issues on recent version of torch_xla.
@tengomucho tengomucho requested a review from muellerzr January 6, 2025 14:49
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will be included in the release this week

@muellerzr muellerzr merged commit 95f34d6 into main Jan 13, 2025
28 checks passed
@muellerzr muellerzr deleted the xmp_spawn-without-num_cores branch January 13, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accelerate fails to initialize on Cloud TPUs
3 participants