Use soundfile for mp3 decoding instead of torchaudio #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
…aries installation
mariosasko
reviewed
Feb 27, 2023
src/datasets/features/audio.py
Outdated
| @@ -243,128 +236,52 @@ def path_to_bytes(path): | |||
| storage = pa.StructArray.from_arrays([bytes_array, path_array], ["bytes", "path"], mask=bytes_array.is_null()) | |||
| return array_cast(storage, self.pa_type) | |||
|
|
|||
| def _decode_non_mp3_path_like( | |||
| self, path, format=None, token_per_repo_id: Optional[Dict[str, Union[str, bool, None]]] = None | |||
| def _decode_example( | |||
There was a problem hiding this comment.
I think we can put all this logic in decode_example and structure it the same way as in Image.decode_example
src/datasets/features/audio.py
Outdated
| try: | ||
| import librosa | ||
| import soundfile as sf | ||
| except ImportError as err: | ||
| raise ImportError("To support decoding audio files, please install 'librosa' and 'soundfile'.") from err | ||
|
|
||
| if format == "opus": | ||
| if version.parse(sf.__libsndfile_version__) < version.parse("1.0.30"): | ||
| if version.parse(sf.__libsndfile_version__) < version.parse("1.0.31"): |
There was a problem hiding this comment.
Perhaps we can introduce 2 module-level variables for these checks:
IS_OPUS_SUPPORTED = version.parse(sf.__libsndfile_version__) < version.parse("1.0.31")
IS_MP3_SUPPORTED = version.parse(sf.__libsndfile_version__) < version.parse("1.0.31")
|
@mariosasko thank you for the review! do you have any idea why |
stevhliu
approved these changes
Feb 27, 2023
Co-authored-by: Mario Šaško <[email protected]>
|
@polinaeterna The failure is due to @pklregister(obj_type)
def _save_tensor(pickler, obj):
# `torch.from_numpy` is not picklable in `torch>=1.11.0`
def _create_tensor(np_array):
return torch.from_numpy(np_array)
dill_log(pickler, f"To: {obj}")
args = (obj.detach().cpu().numpy(),)
pickler.save_reduce(_create_tensor, args, obj=obj)
dill_log(pickler, "# To")
return |
lhoestq
approved these changes
Feb 28, 2023
|
(doing a patch release now - please wait before merging ^^) |
Co-authored-by: Mario Šaško <[email protected]>
|
@mariosasko génial, merci!! i've integrated all your changes, can you pls take a look one more time? |
|
Patch release is done (I did it from another branch than |
Show benchmarksPyArrow==6.0.0 Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
|
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed
torchaudiocompletely and switched to usesoundfilefor everything. With the new version ofsoundfilepackage this should work smoothly because thelibsndfileC library is bundled, in Linux wheels too.Let me know if you think it's too harsh and we should continue to support
torchaudiodecoding.I decided that we can drop it completely because:
torchaudio(for example recently Error loading MP3 files from CommonVoice #5488 )torchaudioversionsoundfileis slightly faster then the latesttorchaudiocc @sanchit-gandhi @vaibhavad