Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary lines #8569

Merged
merged 19 commits into from
Jul 8, 2024
Merged

Remove unnecessary lines #8569

merged 19 commits into from
Jul 8, 2024

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Jun 15, 2024 •
edited
Loading

They are unnecessary lines, aren't they? Self-assigned vars have been found with PLW0127.

@yiyixuxu @DN6

@tolgacangoz tolgacangoz changed the title Remove unused line Remove an unused line Jun 15, 2024
@tolgacangoz tolgacangoz changed the title Remove an unused line [Tests] Remove an unused line Jun 15, 2024
@tolgacangoz tolgacangoz changed the title [Tests] Remove an unused line [Tests] Remove unnecessary lines Jun 15, 2024
@tolgacangoz tolgacangoz changed the title [Tests] Remove unnecessary lines Remove unnecessary lines Jun 15, 2024
@sayakpaul sayakpaul requested a review from yiyixuxu June 18, 2024 15:39
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul requested a review from DN6 June 29, 2024 13:00
a-r-r-o-w
a-r-r-o-w approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for removing the unnecessary lines! i do not know the reasoning behind the duplicate assignments but if it's just a mistake, these changes look good to me. CI looks good as well (failing test seems unrelated)

yiyixuxu
yiyixuxu approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 57084da into huggingface:main Jul 8, 2024
15 checks passed
@yiyixuxu yiyixuxu mentioned this pull request Jul 8, 2024
Closed
@tolgacangoz
Copy link
Contributor Author

Thanks for merging!

@tolgacangoz tolgacangoz deleted the remove-unnecessary-line branch July 8, 2024 21:22
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@tolgacangoz @sayakpaul
Remove unnecessary lines (#8569)
8e64c7f 
* Remove unused line


---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

@yiyixuxu yiyixuxu yiyixuxu approved these changes

@DN6 DN6 Awaiting requested review from DN6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tolgacangoz @HuggingFaceDocBuilderDev @yiyixuxu @a-r-r-o-w @sayakpaul